expand 1.7.x upgrade guide on enable-remote-node-identity #10853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please set the appropriate release note label. |
qmonnet
requested changes
Apr 6, 2020
joestringer
reviewed
Apr 6, 2020
7a40028 to
289c627
Compare
…tity Signed-off-by: Dan Wendlandt <dan@covalent.io>
289c627 to
0809b6b
Compare
|
Thanks for the reviews @qmonnet and @joestringer . All addressed except for 'helm' capitalization per discussion above. |
joestringer
approved these changes
Apr 14, 2020
| app: myapp | ||
| ingress: | ||
| - fromEntities: | ||
| - remote-node |
There was a problem hiding this comment.
I wonder if we should also extend the policy docs here to explicitly call this out; going forward this will affect all new Cilium users, not just the ones upgrading from earlier releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.