cilium: set encrypt node route mtu in encryption table #10741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently made a set of fixes to ensure the route mtu in the encryption routing table (table 200) also sets a correct route in both the direct routing and tunnel case. This fixes the last case I am aware of when encrypt node is set we add a route for remote node IPs. The same as cilium_host IPs these also need to use a route MTU. This is only important when the host MTU is not the standard MTU (1500B). And in this case TCP traffic should should discover correct MSS but still its not ideal to depend on this and further not all traffic is TCP. To reflect GetRouteTunnelMTU is now used in direct routing cases as well rename, GetRoutePostEncryptMTU. Signed-off-by: John Fastabend <john.fastabend@gmail.com>
|
Please set the appropriate release note label. |
|
test-me-please |
joestringer
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made a set of fixes to ensure the route mtu in the encryption
routing table (table 200) also sets a correct route mtu in both the direct
routing and tunnel case.
This fixes the last case I am aware of when encrypt node is set we add
a route for remote node IPs. The same as cilium_host IPs these also
need to use a route MTU. This is only important when the host MTU is
not the standard MTU (1500B). And in this case TCP traffic should
should discover correct MSS but still its not ideal to depend on this
and further not all traffic is TCP.
To reflect GetRouteTunnelMTU is now used in direct routing cases as
well rename, GetRoutePostEncryptMTU.
Signed-off-by: John Fastabend john.fastabend@gmail.com