Skip to content

Conversation

seanmwinn
Copy link
Contributor

@seanmwinn seanmwinn commented Mar 10, 2020

Adds details to System Requirements about cilium features and required kernel versions above 4.9.17, supported OS update
Fixes: #10534
Signed-off-by: Sean Winn sean@isovalent.com


This change is Reviewable

@seanmwinn seanmwinn requested a review from a team as a code owner March 10, 2020 22:22
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@coveralls
Copy link

coveralls commented Mar 10, 2020

Coverage Status

Coverage decreased (-0.06%) to 45.592% when pulling 8d2c688 on seanmwinn:cilium-10534 into 711b37e on cilium:master.

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see references to 4.9.17 in Documentation/concepts/overview.rst, though maybe that document should just point over to here for the kernel requirements now instead of having its own version content / text?

While you're at it, you may consider adding RancherOS per #9825 as well.

Couple of minor fixup requests below.

`Kube-proxy Free`_ >= 4.19.57, >= 5.1.16+, >=5.2+
========================== ===============================

.. _Longest Prefix Match: |SCM_WEB|\/install/upgrade/#restrictions-on-unique-prefix-lengths-for-cidr-policy-rules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When available we also use LRU (Least Recently Used) hash maps with BPF, which appeared in kernel 4.10. But as far as I know we don't have any specific documentation on the topic (not sure it makes a difference to the user, other than for performance), so not sure if worth adding in this table.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for current usage (existing maps) we work around the lack of LRU by just creating a hashmap and spinning up a garbage collection controller in the cilium-agent.

@joestringer
Copy link
Member

test-docs-please

additional supported linux distributions
Fixes: #10534
Signed-off-by: Sean Winn <sean@isovalent.com>
@seanmwinn seanmwinn requested a review from pchaigno March 11, 2020 19:55
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor nit.

@tklauser
Copy link
Member

@seanmwinn @joestringer what's the status of this? I see one small open suggestion which hasn't been incorporated yet. Since this PR is tagged as needs-backport-1.6 and needs-backport-1.7 it would be great to get it merged to master soon, such that we can pick it up for the next round of backports. Thanks.

@joestringer
Copy link
Member

I'll just fold in the suggestion since it's minor and push it through with a 'Squash and Merge'

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Copy link
Member

test-docs-please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Update System Requirements to call out key features/functionality and required kernel versions
7 participants