-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Adds details about required kernel versions above 4.9.17, supported OS update #10537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release note label not set, please set the appropriate release note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see references to 4.9.17
in Documentation/concepts/overview.rst
, though maybe that document should just point over to here for the kernel requirements now instead of having its own version content / text?
While you're at it, you may consider adding RancherOS per #9825 as well.
Couple of minor fixup requests below.
`Kube-proxy Free`_ >= 4.19.57, >= 5.1.16+, >=5.2+ | ||
========================== =============================== | ||
|
||
.. _Longest Prefix Match: |SCM_WEB|\/install/upgrade/#restrictions-on-unique-prefix-lengths-for-cidr-policy-rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When available we also use LRU (Least Recently Used) hash maps with BPF, which appeared in kernel 4.10. But as far as I know we don't have any specific documentation on the topic (not sure it makes a difference to the user, other than for performance), so not sure if worth adding in this table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for current usage (existing maps) we work around the lack of LRU by just creating a hashmap and spinning up a garbage collection controller in the cilium-agent.
test-docs-please |
additional supported linux distributions Fixes: #10534 Signed-off-by: Sean Winn <sean@isovalent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor nit.
@seanmwinn @joestringer what's the status of this? I see one small open suggestion which hasn't been incorporated yet. Since this PR is tagged as |
I'll just fold in the suggestion since it's minor and push it through with a 'Squash and Merge' |
Signed-off-by: Joe Stringer <joe@cilium.io>
test-docs-please |
Adds details to System Requirements about cilium features and required kernel versions above 4.9.17, supported OS update
Fixes: #10534
Signed-off-by: Sean Winn sean@isovalent.com
This change is