Documentation: Lock dependency to fix build #10419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A dependency for building docs imports the PyEnchant library. Which by default pulls in the 'latest' version, this was updated from 2.0.0 to 3.0.1 on 2020/03/01. Using PyEnchant 3.0.1 `make html` fails to build locally as well as in the [test-docs-please](https://jenkins.cilium.io/job/Cilium-PR-Doc-Tests/1921/console) command/build. This change locks PyEnchant at 2.0.0 for the time being until there's a reason to figure out the dependency problems. The root cause isn't obvious, PyEnchant claims `The 'enchant' C library was not found` but it is being installed by `apk` in the container. Potentially file locations have changed in a newer version of the C library and newer PyEnchant expects new locations. Related: cilium#10391 Signed-off-by: Joshua Roppo <joshroppo@gmail.com>
|
Release note label not set, please set the appropriate release note. |
pchaigno
approved these changes
Mar 3, 2020
|
test-docs-please |
aanm
approved these changes
Mar 3, 2020
This was referenced Mar 3, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dependency for building docs imports the PyEnchant library.
Which by default pulls in the 'latest' version, this was updated from
2.0.0 to 3.0.1 on 2020/03/01.
Using PyEnchant 3.0.1
make htmlfails to build locally as well as inthe test-docs-please command/build.
This change locks PyEnchant at 2.0.0 for the time being until there's a
reason to figure out the dependency problems. The root cause isn't
obvious, PyEnchant claims
The 'enchant' C library was not foundbutit is being installed by
apkin the container. Potentially filelocations have changed in a newer version of the C library and newer
PyEnchant expects new locations.
PR inspiring this fix
Related: #10391
Signed-off-by: Joshua Roppo joshroppo@gmail.com
This change is