Add Kubernetes IPAM mode #10407
Merged
Add Kubernetes IPAM mode #10407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
requested changes
Mar 2, 2020
Does anything change for the user? This should be invisible except for the help text and the logfile which now documents that the legacy hostscope is in use. |
5e4726f to
156324c
Compare
|
test-me-please |
aanm
approved these changes
Mar 3, 2020
156324c to
e7f479e
Compare
In order to test different IPAM modes easily in the future, remove direct access to option.Config in order to allow mocking the configuration interface. Signed-off-by: Thomas Graf <thomas@cilium.io>
Explicitly set the current default IPAM mode in the viper option. This enables introduction of a better default. Signed-off-by: Thomas Graf <thomas@cilium.io>
This documents an IPAM mode which was already supported and widely used but difficult to discover. The new "kubernete" IPAM mode requires the PodCIDR for all enabled address families to be provided via the k8s Node resource and then uses the standard hostscope allocator. Signed-off-by: Thomas Graf <thomas@cilium.io>
e7f479e to
e79a9e4
Compare
|
test-me-please |
tklauser
added a commit
that referenced
this pull request
Mar 4, 2020
This was introduced by #10407 and makes the spell checker fail. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
This was referenced Mar 4, 2020
tgraf
pushed a commit
that referenced
this pull request
Mar 4, 2020
This was introduced by #10407 and makes the spell checker fail. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is