v1.6 backports 2020-03-06 #10499
Merged
v1.6 backports 2020-03-06 #10499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 6abebd0 ] Previously, WaitforPods() could prematurely return when kub.GetPods() returned no pods (e.g. WaitforPods() had been immediately called after sending a create pods request). To avoid this, we should wait (by returning false) when the pod list is empty instead of setting the minRequired. This makes the function to fail when a user intentionally set minRequired to 0 in WaitforNPodsRunning(), but I don't see any sane use case where setting minRequired to 0 would make sense. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
|
never-tell-me-the-odds |
joestringer
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: commit 2449dfb was not needed, there is no such test in 1.6
Not backported as these depend on other changes not backported to v1.6:
Once this PR is merged, you can update the PR labels via:
This change is