Skip to content

doc: Update EKS documentation to delete aws-node #10461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

doc: Update EKS documentation to delete aws-node #10461

merged 1 commit into from
Mar 4, 2020

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Mar 4, 2020 •
edited by tgraf
Loading

It has been confirmed that VPC CNI can be delete and EKS will not try to restore it.

Fixes: #10420

doc: Update EKS documentation to delete aws-node

This change is Reviewable

@errordeveloper errordeveloper requested a review from a team as a code owner March 4, 2020 13:27
@maintainer-s-little-helper

This comment has been minimized.

Sign in to view
@errordeveloper errordeveloper added the release-note/misc This PR makes changes that have no direct user impact. label Mar 4, 2020
@coveralls
Copy link

coveralls commented Mar 4, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 45.644% when pulling 25c2501 on pr/errordeveloper/eks-doc-remove-aws-node into 647a43c on master.

qmonnet
qmonnet requested changes Mar 4, 2020
View reviewed changes
@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Mar 4, 2020
@maintainer-s-little-helper

This comment has been minimized.

Sign in to view
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 4, 2020
@errordeveloper errordeveloper force-pushed the pr/errordeveloper/eks-doc-remove-aws-node branch from 5fc604b to 466dd2c Compare March 4, 2020 15:00
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 4, 2020
@errordeveloper errordeveloper requested a review from qmonnet March 4, 2020 15:01
qmonnet
qmonnet requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there was two suggestions, looks like the first one was not very visible.

@errordeveloper
doc: Update EKS documentation to delete aws-node
25c2501 
It has been confirmed that VPC CNI can be delete and EKS will not
try to restore it.

Fixes #10420

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper errordeveloper force-pushed the pr/errordeveloper/eks-doc-remove-aws-node branch from 466dd2c to 25c2501 Compare March 4, 2020 17:09
@errordeveloper errordeveloper requested a review from qmonnet March 4, 2020 17:30
@qmonnet
Copy link
Member

qmonnet commented Mar 4, 2020

test-docs-please

@tgraf tgraf merged commit d288b07 into master Mar 4, 2020
@tgraf tgraf deleted the pr/errordeveloper/eks-doc-remove-aws-node branch March 4, 2020 20:56
@errordeveloper errordeveloper mentioned this pull request Mar 6, 2020
Closed
@christarazi christarazi mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate if the built-in CNI driver in EKS can be deleted (and update docs accordingly)
6 participants
@errordeveloper @coveralls @qmonnet @tgraf @christarazi @aanm