-
Notifications
You must be signed in to change notification settings - Fork 3.4k
test: Wait for Istio POD termination before deleting istio-system or cilium #10325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
raybejjani
merged 1 commit into
master
from
pr/jrajahalme/istio-assert-terminating-pods
Feb 25, 2020
Merged
test: Wait for Istio POD termination before deleting istio-system or cilium #10325
raybejjani
merged 1 commit into
master
from
pr/jrajahalme/istio-assert-terminating-pods
Feb 25, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cilium Recently Istio PODs have been lingering in terminating state long after deletion. It appears that kubelet on k8s2-1.17 is not happy that istio-system namespace has been deleted. Deletion of the namespace usually automatically deletes all the PODs in it. It may also be that the termination fails to complete since the Cilium DS is being deleted right after the istio-system namespace is deleted. k8s2 kubelet[3338]: W0225 ... 3338 status_manager.go:546] Failed to update status for pod "istio-citadel-7859cc956c-74474_istio-system(9a0a2875-076b-4670-a9b4-13f92f6c7240)": failed to patch status "... \"state\":{\"terminated\":{\"exitCode\":0,\"finishedAt\":null,\"startedAt\":null}}" for pod "istio-system"/"istio-citadel-7859cc956c-74474": namespaces "istio-system" not found Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
test-me-please |
CI for #10299 seems to be consistently failing due to Istio PODs on k8s2-1.17 not terminating. This should fix that. |
ianvernon
approved these changes
Feb 25, 2020
test-missed-k8s |
nebril
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
area/k8s
Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
kind/bug/CI
This is a bug in the testing code.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently Istio PODs have been lingering in terminating state long
after deletion. It appears that kubelet on k8s2-1.17 is not happy that
istio-system namespace has been deleted. Deletion of the namespace
usually automatically deletes all the PODs in it. It may also be that
the termination fails to complete since the Cilium DS is being deleted
right after the istio-system namespace is deleted.
k8s2 kubelet[3338]: W0225 ... 3338 status_manager.go:546] Failed to update status for pod "istio-citadel-7859cc956c-74474_istio-system(9a0a2875-076b-4670-a9b4-13f92f6c7240)": failed to patch status "... "state":{"terminated":{"exitCode":0,"finishedAt":null,"startedAt":null}}" for pod "istio-system"/"istio-citadel-7859cc956c-74474": namespaces "istio-system" not found
This change is