Skip to content

test: Wait for Istio POD termination before deleting istio-system or cilium #10325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Feb 25, 2020

Recently Istio PODs have been lingering in terminating state long
after deletion. It appears that kubelet on k8s2-1.17 is not happy that
istio-system namespace has been deleted. Deletion of the namespace
usually automatically deletes all the PODs in it. It may also be that
the termination fails to complete since the Cilium DS is being deleted
right after the istio-system namespace is deleted.

k8s2 kubelet[3338]: W0225 ... 3338 status_manager.go:546] Failed to update status for pod "istio-citadel-7859cc956c-74474_istio-system(9a0a2875-076b-4670-a9b4-13f92f6c7240)": failed to patch status "... "state":{"terminated":{"exitCode":0,"finishedAt":null,"startedAt":null}}" for pod "istio-system"/"istio-citadel-7859cc956c-74474": namespaces "istio-system" not found


This change is Reviewable

…cilium

Recently Istio PODs have been lingering in terminating state long
after deletion. It appears that kubelet on k8s2-1.17 is not happy that
istio-system namespace has been deleted. Deletion of the namespace
usually automatically deletes all the PODs in it. It may also be that
the termination fails to complete since the Cilium DS is being deleted
right after the istio-system namespace is deleted.

  k8s2 kubelet[3338]: W0225 ... 3338 status_manager.go:546] Failed to update status for pod "istio-citadel-7859cc956c-74474_istio-system(9a0a2875-076b-4670-a9b4-13f92f6c7240)": failed to patch status "... \"state\":{\"terminated\":{\"exitCode\":0,\"finishedAt\":null,\"startedAt\":null}}" for pod "istio-system"/"istio-citadel-7859cc956c-74474": namespaces "istio-system" not found

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added pending-review kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/ci This PR makes changes to the CI. labels Feb 25, 2020
@jrajahalme jrajahalme requested a review from a team as a code owner February 25, 2020 01:54
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme
Copy link
Member Author

CI for #10299 seems to be consistently failing due to Istio PODs on k8s2-1.17 not terminating. This should fix that.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 45.51% when pulling 946c2bc on pr/jrajahalme/istio-assert-terminating-pods into 43f7824 on master.

@nebril
Copy link
Member

nebril commented Feb 25, 2020

test-missed-k8s

Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants