cilium: fix node-port range parsing from helm and update docs #10382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release note label not set, please set the appropriate release note. |
2 similar comments
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
houndci-bot
reviewed
Feb 28, 2020
Right now setting NodePort range via helm is broken, similarly as described in b365463 ("helm: fix host reachable services template for cilium config map") for host-reachable services when we would want to specify 'tcp,udp'. Given latter is default, it does not matter that much, but users ran into the same issue for the NodePort range where the string slice from configmap gets flattened into a string slice of 1 element with a comma-separated list thus resulting into parsing errors. Detect and fix both cases by strings.Split() on the comma. Fixes: #10375 Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Helm is a mess in that it needs a workaround to specify the comma through '\,'. Given this is non-obvious, add an example. Fixes: #10375 Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
... and that this will be fixed in future Cilium versions. Related: #10359 Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
51dc6e9 to
829de82
Compare
|
test-me-please |
|
test-docs-please |
brb
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msg. /cc @brb
This change is