Skip to content

pkg/bpf: Protect attr in perf_linux.go with runtime.KeepAlive #10205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2020
Merged

pkg/bpf: Protect attr in perf_linux.go with runtime.KeepAlive #10205

merged 1 commit into from
Feb 17, 2020

Conversation

brb
Copy link
Member

@brb brb commented Feb 17, 2020 •
edited by tgraf
Loading

Otherwise, the Go's GC might collect it while the syscall is being executed. See #10168 for more context.

This change is Reviewable

@brb
pkg/bpf: Protect attr in perf_linux.go with runtime.KeepAlive
5a44b4a 
Otherise, the Go's GC might collect it while the syscall is being
executed. See #10168 for more
context.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. backport-pending/1.5 labels Feb 17, 2020
@brb brb requested a review from a team as a code owner February 17, 2020 11:32
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.5 kind/backports This PR provides functionality previously merged into master. labels Feb 17, 2020
@brb
Copy link
Member Author

brb commented Feb 17, 2020

test-me-please

@brb brb requested a review from aanm February 17, 2020 11:32
@aanm
Copy link
Member

aanm commented Feb 17, 2020

never-tell-me-the-odds

@aanm aanm added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Feb 17, 2020
@aanm aanm merged commit e66b5e7 into v1.5 Feb 17, 2020
@aanm aanm deleted the pr/brb/rt-keepalive-perf-1.5 branch February 17, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/backports This PR provides functionality previously merged into master. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brb @aanm