bpf: Fix space hack in Makefile #10173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the space hack which stopped working with make v4.3 (works with
v4.2 though):
[..]
" [-DENABLE_HOST_REDIRECT-DENABLE_IPV4-DENABLE_IPV6-DENABLE_NAT46]";
clang -DENABLE_HOST_REDIRECT-DENABLE_IPV4-DENABLE_IPV6-DENABLE_NAT46
-I/home/brb/sandbox/gopath/src/github.com/cilium/cilium/bpf/include
-I/home/brb/sandbox/gopath/src/github.com/cilium/cilium/bpf
-D__NR_CPUS__=8 -O2 -g -target bpf -emit-llvm -Wall -Werror
-Wno-address-of-packed-member -Wno-unknown-warning-option -c bpf_lxc.c
-o bpf_lxc.ll; llc -march=bpf -mcpu=probe -mattr=dwarfris -o /dev/null
bpf_lxc.ll; \
fi
In file included from <built-in>:323:
<command line>:1:20: error: ISO C99 requires whitespace after the macro
name [-Werror,-Wc99-extensions]
#define ENABLE_IPV4-DHAVE_LPM_MAP_TYPE 1
Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
test-me-please |
|
CI provisioning failed. re-running. |
|
test-me-please |
aanm
approved these changes
Feb 13, 2020
gandro
added a commit
to cilium/hubble
that referenced
this pull request
Feb 17, 2020
GNU make v4.3 breaks trailing slashes. This inserts the trailing space in the api/v1/Makefile by introduce an $space variable containing a single space. Without this fix, generating the gRPC API breaks with the following error: ```console $ make -C api/v1 :( [...] google,Mprotobuf,Mduration.proto=github.com,Mgogo,Mprotobuf,Mtypes,M: No such file or directory make: *** [Makefile:32: flow/flow.pb.go] Error 1 ``` See also cilium/cilium#10173 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added a commit
to cilium/hubble
that referenced
this pull request
Feb 17, 2020
GNU make v4.3 breaks trailing slashes. This inserts the trailing space in the api/v1/Makefile by introduce an $space variable containing a single space. Without this fix, generating the gRPC API breaks with the following error: ```console $ make -C api/v1 [...] google,Mprotobuf,Mduration.proto=github.com,Mgogo,Mprotobuf,Mtypes,M: No such file or directory make: *** [Makefile:32: flow/flow.pb.go] Error 1 ``` See also cilium/cilium#10173 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added a commit
to cilium/hubble
that referenced
this pull request
Feb 17, 2020
GNU make v4.3 breaks trailing slashes. This inserts the trailing space in the api/v1/Makefile by introduce an $space variable containing a single space. Without this fix, generating the gRPC API breaks with the following error: ```console $ make -C api/v1 [...] google,Mprotobuf,Mduration.proto=github.com,Mgogo,Mprotobuf,Mtypes,M: No such file or directory make: *** [Makefile:32: flow/flow.pb.go] Error 1 ``` See also cilium/cilium#10173 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
michi-covalent
pushed a commit
to cilium/hubble
that referenced
this pull request
Feb 17, 2020
GNU make v4.3 breaks trailing slashes. This inserts the trailing space in the api/v1/Makefile by introduce an $space variable containing a single space. Without this fix, generating the gRPC API breaks with the following error: ```console $ make -C api/v1 [...] google,Mprotobuf,Mduration.proto=github.com,Mgogo,Mprotobuf,Mtypes,M: No such file or directory make: *** [Makefile:32: flow/flow.pb.go] Error 1 ``` See also cilium/cilium#10173 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
This was referenced Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the space hack which stopped working with make v4.3 (works with v4.2 though):
This change is