Skip to content

Update release process steps #10035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2020
Merged

Update release process steps #10035

merged 5 commits into from
Feb 4, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented Feb 3, 2020

This change is Reviewable

@aanm aanm requested a review from a team as a code owner February 3, 2020 18:31
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

1 similar comment
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Feb 3, 2020
@aanm
Copy link
Member Author

aanm commented Feb 3, 2020

test-docs-please

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Won't backport cleanly to v1.5 because of docs refactoring. (Might not even backport to v1.6 for the same reason..)

@coveralls
Copy link

coveralls commented Feb 3, 2020

Coverage Status

Coverage decreased (-0.007%) to 44.755% when pulling 4f8748d on pr/update-release-process into a41fc6e on master.

aanm added 5 commits February 3, 2020 22:52
Signed-off-by: André Martins <andre@cilium.io>
This step is automatically generated by a command ran afterwards:
`make -C install/kubernetes clean all`

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
We will include the automated release notes generated in the Github
release page.

Signed-off-by: André Martins <andre@cilium.io>
`git shortlog v1.0.2..` can be executed by anyone in their terminal and
since we now have auto-generated release-notes it does not make sense to
run this step anymore.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/update-release-process branch from fbec520 to 4f8748d Compare February 3, 2020 21:52
@aanm
Copy link
Member Author

aanm commented Feb 3, 2020

test-docs-please

@aanm aanm merged commit dec65a6 into master Feb 4, 2020
@aanm aanm deleted the pr/update-release-process branch February 4, 2020 09:37
@jrfastab
Copy link
Contributor

@aanm I did some grep'ing in the 1.5 docs and can't find any of the phrases that would match these fixes. Any objection to dropping this from 1.5 Backports. If its important lets open an issue to refresh 1.5 documentation but I think its probably good-enough as-is and would focus more on current docs over contributing guides for 1.5

@jrfastab
Copy link
Contributor

Actually I see what happened @raybejjani seems this is already merged we just missed updating tags?

@aanm
Copy link
Member Author

aanm commented Feb 20, 2020

@jrfastab yeah I think that's what happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants