Skip to content

TLS follow-up fixes #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 8, 2020
Merged

TLS follow-up fixes #9807

merged 4 commits into from
Jan 8, 2020

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Jan 3, 2020 •
edited by tgraf
Loading

These commits address the rest of the review comments on #9486

This change is Reviewable

@jrajahalme
crypto: Simplify error handling in certificatesmanager.
2981056 
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme
k8s: Make secret name and TLS context secret required policy fields.
7a5bcf2 
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme
tls: Fix comments and logging
cf84a47 
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme
policy/api: Factor out Secret.Equal()
2bf0652 
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added kind/enhancement This would improve or streamline existing functionality. pending-review area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. labels Jan 3, 2020
@jrajahalme jrajahalme requested review from a team as code owners January 3, 2020 22:32
@jrajahalme jrajahalme requested a review from a team January 3, 2020 22:32
@jrajahalme jrajahalme requested a review from a team as a code owner January 3, 2020 22:32
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

2 similar comments
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@jrajahalme jrajahalme added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note labels Jan 3, 2020
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme jrajahalme mentioned this pull request Jan 3, 2020
Merged
@jrajahalme jrajahalme requested a review from joestringer January 3, 2020 22:34
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 45.862% when pulling 2bf0652 on pr/jrajahalme/envoy-tls-followup-fixes into 353a20c on master.

aanm
aanm requested changes Jan 6, 2020
View reviewed changes
@aanm aanm merged commit 6c23f97 into master Jan 8, 2020
@aanm aanm deleted the pr/jrajahalme/envoy-tls-followup-fixes branch January 8, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@joestringer joestringer Awaiting requested review from joestringer

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrajahalme @coveralls @aanm