1.6 CI fixes #8779
Merged
1.6 CI fixes #8779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a no-op as the manifests have been removed but no error was reported so this failed silently without any effect. Signed-off-by: Thomas Graf <thomas@cilium.io>
As the manifests are no longer available, use resource names to remove the etcd-operator. Signed-off-by: Thomas Graf <thomas@cilium.io>
The call to CiliumInstall() will deploy CoreDNS again but then not remove it. Remove it properly at the end of the test. Signed-off-by: Thomas Graf <thomas@cilium.io>
|
test-me-please EDIT: green build |
nebril
approved these changes
Aug 5, 2019
18f3c77 to
7640510
Compare
|
test-me-please The following tests failed:
|
ianvernon
reviewed
Aug 5, 2019
| return err | ||
| } | ||
|
|
||
| res := kub.Delete("cilium.yaml") |
There was a problem hiding this comment.
Do we generate different resources in K8s based off of the Helm options? Most of these appear to be options provided to the DaemonSet / ConfigMap - can you elaborate on what K8s resources are different depending upon the Helm options?
There was a problem hiding this comment.
- Inclusion of etcd-operator and related ClusterRole, ClusterRoleBinding and ServiceAccount.
This allows to remove all Cilium resources based on the Helm template. Use it for the upgrade/downgrade test to properly remove all remaining resources. Signed-off-by: Thomas Graf <thomas@cilium.io>
CoreDNS is installed in the tests themselves using the right version. Other tests do not depend on CoreDNS running. Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
7640510 to
1d7c08c
Compare
|
test-me-please |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to address 1.6 CI stability
Fixes: #8775
This change is