Skip to content

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented May 29, 2019

Dump() now returns nil maps if an address family is disabled

Fixes: ef23e9c ("ipam: Define interface for allocator")


This change is Reviewable

Dump() now returns nil maps if an address family is disabled

Fixes: ef23e9c ("ipam: Define interface for allocator")

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added kind/bug This is a bug in the Cilium logic. pending-review labels May 29, 2019
@tgraf tgraf requested a review from a team May 29, 2019 08:34
@tgraf
Copy link
Member Author

tgraf commented May 29, 2019

test-me-please

Build got cancelled

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 41.922% when pulling 8df50af on pr/tgraf/fix-ipam into c347b6c on master.

@tgraf
Copy link
Member Author

tgraf commented May 29, 2019

test-me-please (timed out in STEP: Checking pod connectivity between nodeshttps://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/12663)

@raybejjani
Copy link
Contributor

test-me-please

1 similar comment
@tgraf
Copy link
Member Author

tgraf commented May 29, 2019

test-me-please

@tgraf tgraf merged commit a484487 into master May 29, 2019
@tgraf tgraf deleted the pr/tgraf/fix-ipam branch May 29, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants