Skip to content

Prepare IPAM for multiple backends #8016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2019
Merged

Prepare IPAM for multiple backends #8016

merged 3 commits into from
May 15, 2019

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented May 14, 2019 •
edited
Loading

This is in preparation for CRD-backed IPAM. It introduces an interface to implement and moves the existing hostscope allocator to become a backend. It also moves the status definition logic from the client into the backend so different backends can provide backend specific status messages.

This change is Reviewable

tgraf added 3 commits May 14, 2019 17:42
@tgraf
ipam: Define interface for allocator
22ed393 
This prepares the IPAM layer to support multiple implementations. No functional
changes are made in this commit.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
ipam: Provide ipam information in debuginfo
b37aa3b 
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
ipam: Allow IPAM backend to provide its own status
d76de4e 
Move logic from cilium client into IPAM backend plugin

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf requested a review from a team May 14, 2019 15:44
@tgraf tgraf requested review from a team as code owners May 14, 2019 15:44
@tgraf tgraf added pending-review priority/high This is considered vital to an upcoming release. labels May 14, 2019
@tgraf tgraf added this to the 1.6.0 milestone May 14, 2019
@tgraf
Copy link
Member Author

tgraf commented May 14, 2019 •
edited
Loading

test-me-please

k8s provision error:
00:15:48.387      k8s2-1.10: [discovery] Failed to request cluster info, will try again: [Get https://192.168.36.11:6443/api/v1/namespaces/kube-public/configmaps/cluster-info: dial tcp 192.168.36.11:6443: getsockopt: no route to host]

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 41.878% when pulling d76de4e on pr/tgraf/ipam-api into 478f9ac on master.

@tgraf
Copy link
Member Author

tgraf commented May 14, 2019 •
edited
Loading

test-me-please

Hit #7797: etcd never achieved quorum

joestringer
joestringer approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgraf
Copy link
Member Author

tgraf commented May 14, 2019 •
edited
Loading

test-me-please

Known flake

Suite-runtime.RuntimeCassandra Tests policy allowing all actions
```

@tgraf
Copy link
Member Author

tgraf commented May 14, 2019

test-me-please

@tgraf tgraf merged commit a7769de into master May 15, 2019
@tgraf tgraf deleted the pr/tgraf/ipam-api branch May 15, 2019 07:48
@vadorovsky vadorovsky mentioned this pull request Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
priority/high This is considered vital to an upcoming release.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tgraf @coveralls @joestringer @vadorovsky