Skip to content

Conversation

borkmann
Copy link
Member

After rebase, fix the related code wrt uapi changes. Note that
perf ring buffer formats will change and Go code needs to adapt
as we no longer zero pad the tail if skb length is < 64, and pass
original and captured length as meta data.

Signed-off-by: Daniel Borkmann daniel@cilium.io

@tgraf
Copy link
Member

tgraf commented Jul 19, 2016

I'll update the Go side after the new kernel image has been built.

@tgraf tgraf force-pushed the after-rebase branch 2 times, most recently from 30c348e to 0add11e Compare July 19, 2016 23:07
After rebase, fix the related code wrt uapi changes. Note that
perf ring buffer formats will change and Go code needs to adapt
as we no longer zero pad the tail if skb length is < 64, and pass
original and captured length as meta data.

Signed-off-by: Daniel Borkmann <daniel@cilium.io>
Acked-by: Thomas Graf <thomas@cilium.io>
@tgraf
Copy link
Member

tgraf commented Jul 19, 2016

ping @aanm can you have a look at the go bits?

@aanm aanm added the acked label Jul 19, 2016
@aanm
Copy link
Member

aanm commented Jul 19, 2016

@tgraf Go bits LGTM, I left the pending-review label there since I wasn't sure if you are still looking at the C bits.

tgraf added 2 commits July 20, 2016 13:48
Acked-by: Andrà Martins <andre@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Acked-by: André Martins <andre@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants