Skip to content

bpf: lxc: remove unused IPsec code in encap handling #41464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

bpf: lxc: remove unused IPsec code in encap handling #41464

merged 1 commit into from
Sep 4, 2025

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Sep 2, 2025 •
edited
Loading 

With the switch to encrypted overlay, the encap code no longer returns
CTX_ACT_OK (which previously indicated that packets need to first pass
through the stack for XFRM processing, prior to overlay encapsulation).

Also fix up the naming of the goto label, it's not related to encryption
any longer.

@julianwiedmann
bpf: lxc: remove unused IPsec code in encap handling
93ee618 
With the switch to encrypted overlay, the encap code no longer returns
CTX_ACT_OK (which previously indicated that packets need to first pass
through the stack for XFRM processing, prior to overlay encapsulation).

Also fix up the naming of the goto label, it's not related to encryption
any longer.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. feature/ipsec Relates to Cilium's IPsec feature labels Sep 2, 2025
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/bpf-lxc-ipsec branch from e5328af to 93ee618 Compare September 2, 2025 09:37
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title Pr/jwi/main/bpf lxc ipsec bpf: lxc: remove unused IPsec code in encap handling Sep 2, 2025
@julianwiedmann julianwiedmann marked this pull request as ready for review September 2, 2025 11:34
@julianwiedmann julianwiedmann requested a review from a team as a code owner September 2, 2025 11:34
@julianwiedmann julianwiedmann added this pull request to the merge queue Sep 4, 2025
Merged via the queue into main with commit 572693d Sep 4, 2025
420 of 422 checks passed
@julianwiedmann julianwiedmann deleted the pr/jwi/main/bpf-lxc-ipsec branch September 4, 2025 05:01
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 4, 2025
julianwiedmann added a commit that referenced this pull request Sep 4, 2025
@julianwiedmann
bpf: remove testing with ENABLE_IPSEC for bpf_lxc
251a419 
#41487 and
#41464 removed the last bits of
IPsec-related code in bpf_lxc. Strip down the compile & load testing
accordingly.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann mentioned this pull request Sep 4, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 5, 2025
@julianwiedmann
bpf: remove testing with ENABLE_IPSEC for bpf_lxc
42f132a 
#41487 and
#41464 removed the last bits of
IPsec-related code in bpf_lxc. Strip down the compile & load testing
accordingly.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysksuzuki ysksuzuki ysksuzuki approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/ipsec Relates to Cilium's IPsec feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianwiedmann @ysksuzuki