bpf: wireguard: re-add IPv6 fragment check in from-wireguard #41451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smagnani96 👋 does this make sense, or did we have some reason for not carrying the fragmentation-check over? The impact is probably fairly minimal ... |
|
/test |
smagnani96
approved these changes
Sep 1, 2025
There was a problem hiding this comment.
@smagnani96 👋 does this make sense, or did we have some reason for not carrying the fragmentation-check over? The impact is probably fairly minimal ...
Yep, it does make sense, dropping these bits was unintentional 😅
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was added in #38110, when we still used
from-netdevfor the wireguard interface. But as #38077 was developed in parallel, it looks like the change was accidentally dropped when introducing the dedicatedfrom-wireguardprogram.