Skip to content

.github/workflows: simplify ginkgo workflow #41396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

.github/workflows: simplify ginkgo workflow #41396

merged 1 commit into from
Aug 28, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented Aug 27, 2025

Add the common steps for the ginkgo workflow so that we can remove boilerplate code from it.

@aanm aanm added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Aug 27, 2025
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from 01ef661 to cfbc14a Compare August 27, 2025 08:41
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from cfbc14a to 54f9c03 Compare August 27, 2025 08:55
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from 54f9c03 to 61e040b Compare August 27, 2025 10:07
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from 61e040b to f39ca68 Compare August 27, 2025 10:16
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from f39ca68 to f658c9f Compare August 27, 2025 11:04
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from f658c9f to 09636af Compare August 27, 2025 12:23
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm added the needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch label Aug 27, 2025
@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from 09636af to e1b02e4 Compare August 27, 2025 13:26
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from e1b02e4 to 8dbc8af Compare August 27, 2025 14:02
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from 8dbc8af to 8c8eaff Compare August 27, 2025 14:44
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from 8c8eaff to adcd07c Compare August 27, 2025 14:58
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm aanm force-pushed the pr/fix-ginkgo-common-steps branch from adcd07c to 50a3b8b Compare August 27, 2025 15:35
@aanm
Copy link
Member Author

aanm commented Aug 27, 2025

/ci-ginkgo

@aanm
Copy link
Member Author

aanm commented Aug 28, 2025

/test

@aanm aanm marked this pull request as ready for review August 28, 2025 05:01
@aanm aanm requested a review from a team as a code owner August 28, 2025 05:01
@aanm aanm added the needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch label Sep 2, 2025
@aanm aanm mentioned this pull request Sep 2, 2025
Merged
@viktor-kurchenko viktor-kurchenko mentioned this pull request Sep 2, 2025
Merged
18 tasks
@viktor-kurchenko viktor-kurchenko added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Sep 2, 2025
@aanm aanm added backport/author The backport will be carried out by the author of the PR. needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. backport/author The backport will be carried out by the author of the PR. labels Sep 3, 2025
@tklauser tklauser mentioned this pull request Sep 9, 2025
Merged
14 tasks
@tklauser tklauser added the backport/author The backport will be carried out by the author of the PR. label Sep 9, 2025
@tklauser
Copy link
Member

tklauser commented Sep 9, 2025

Hit non-trivial merge conflicts when attempting to backport this PR to all the stable branches. Marked as backport/author.

@github-actions github-actions bot added the backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. label Sep 9, 2025
@aanm aanm added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. backport/author The backport will be carried out by the author of the PR. and removed backport/author The backport will be carried out by the author of the PR. needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. labels Sep 9, 2025
@aanm aanm mentioned this pull request Sep 10, 2025
Merged
3 tasks
@aanm aanm added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Sep 10, 2025
@aanm aanm mentioned this pull request Sep 10, 2025
Merged
1 task
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport/author The backport will be carried out by the author of the PR. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aanm @tklauser @joestringer @christarazi @viktor-kurchenko