Skip to content

Conversation

smagnani96
Copy link
Contributor

Please refer to commits.
Let me know if the behavior was intentional, otherwise let's proceed with the PR.

cc. @dylandreimerink

In next commit we will enable such unparallel test. However, there
is an import error missing safenetlink. This commits fixes it.

Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
Prior to this commit, we were never running unparallel tests under
pkg/datapath/loader such as TestPrivilegedSetupIPIPDevices.
With this, that pkg is also taken into account.

Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
Prior to this commit, we were never running unparallel tests under
pkg/datapath/neighbor/test such as TestPrivilegedScript.
With this, that pkg is also taken into account.

Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
@smagnani96 smagnani96 self-assigned this Aug 26, 2025
@smagnani96 smagnani96 added kind/bug This is a bug in the Cilium logic. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Aug 26, 2025
@smagnani96
Copy link
Contributor Author

/test

@smagnani96 smagnani96 marked this pull request as ready for review August 26, 2025 21:17
@smagnani96 smagnani96 requested review from a team as code owners August 26, 2025 21:17
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was not intentional. Honestly I find the whole parallel vs unparallel tests really messy in terms of how we execute them via make. Thanks for fixing it.

@smagnani96
Copy link
Contributor Author

@cilium/build Gente ping 🙏🏼

Copy link
Member

@HadrienPatte HadrienPatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HadrienPatte HadrienPatte removed the request for review from hemanthmalla September 1, 2025 08:30
@HadrienPatte HadrienPatte added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 1, 2025
@dylandreimerink dylandreimerink added this pull request to the merge queue Sep 1, 2025
Merged via the queue into main with commit 46af492 Sep 1, 2025
425 of 429 checks passed
@dylandreimerink dylandreimerink deleted the pr/smagnani96/fix-ci-netlink-tests branch September 1, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants