loadbalancer/maps: use SilentDelete to ignore spurious errors #41378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbmaps.go had code to ignore any expected ErrKeyNotExist errors on deletion. However, this still caused the metric cilium_bpf_map_ops_total error counter to increment. The BPF wrapper already exposes the `SilentDelete()` function, which correctly prevents the error metric from being incremented. Use that instead, and remove the special-casing of ErrKeyDoesNotExist in the loadbalancer code. Fixes: cilium#41255 Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Closed
3 tasks
|
/test |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lbmaps.go had code to ignore any expected ErrKeyNotExist errors on deletion. However, this still caused the metric cilium_bpf_map_ops_total error counter to increment.
The BPF wrapper already exposes the
SilentDelete()function, which correctly prevents the error metric from being incremented. Use that instead, and remove the special-casing of ErrKeyDoesNotExist in the loadbalancer code.Fixes: #41255