Skip to content

kpr: Remove some deprecated flags #41238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 20, 2025
Merged

kpr: Remove some deprecated flags #41238

merged 6 commits into from
Aug 20, 2025

Conversation

brb
Copy link
Member

@brb brb commented Aug 18, 2025 •
edited
Loading

Fix #39583
Fix #39851
Fix #39900

@brb brb added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/agent Cilium agent related. labels Aug 18, 2025
@brb
Copy link
Member Author

brb commented Aug 18, 2025

/test

@brb brb force-pushed the pr/brb/kpr-rm-subflags branch 3 times, most recently from 3fd50e5 to e7b70d4 Compare August 19, 2025 11:35
@brb
Copy link
Member Author

brb commented Aug 19, 2025

/test

@brb brb force-pushed the pr/brb/kpr-rm-subflags branch from e7b70d4 to 8defaed Compare August 19, 2025 14:08
@brb
Copy link
Member Author

brb commented Aug 19, 2025

/test

@brb brb marked this pull request as ready for review August 19, 2025 14:19
@brb brb requested review from a team as code owners August 19, 2025 14:20
derailed
derailed approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brb Nice!

joestringer
joestringer reviewed Aug 19, 2025
View reviewed changes
brb added 5 commits August 20, 2025 08:56
@brb
agent/helm: Remove deprecated EnableSessionAffinity
da8b53d 
The datapath changes will follow in a subsequent commit.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb
bpf: Remove ENABLE_SESSION_AFFINITY
e873afc 
From now on, it's enabled by default.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb
agent/helm: Remove deprecated EnableInternalTrafficPolicy
f61e96d 
The feature is unconditionally enabled.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb
agent/helm: Remove deprecated EnableSVCSourceRangeChecks
49960bd 
A subsequent commit will remove ENABLE_SVC_RANGE_CHECK in the datapath.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb
bpf: Remove ENABLE_SRC_RANGE_CHECK
8a4e6b5 
Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb brb force-pushed the pr/brb/kpr-rm-subflags branch from 8defaed to 1fe7648 Compare August 20, 2025 07:01
@brb brb requested a review from a team as a code owner August 20, 2025 07:01
@brb brb requested a review from fristonio August 20, 2025 07:01
@brb
docs: Mention removals in upgrade docs
3b45b45 
Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb brb force-pushed the pr/brb/kpr-rm-subflags branch from 1fe7648 to 3b45b45 Compare August 20, 2025 07:02
@brb brb requested a review from joestringer August 20, 2025 07:02
@brb
Copy link
Member Author

brb commented Aug 20, 2025

/test

@joestringer joestringer added this pull request to the merge queue Aug 20, 2025
Merged via the queue into main with commit d7cfc96 Aug 20, 2025
363 of 368 checks passed
@joestringer joestringer deleted the pr/brb/kpr-rm-subflags branch August 20, 2025 16:13
@pchaigno pchaigno mentioned this pull request Aug 20, 2025
Closed
julianwiedmann added a commit that referenced this pull request Sep 5, 2025
@julianwiedmann
bpf: complexity-tests: remove ENABLE_{SRC_RANGE_CHECK, SESSION_AFFINITY}
ce61ef0 
#41238 raced against another
PR that introduced additional config files with these unused config
options. Clean it up.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Sep 10, 2025
@julianwiedmann
bpf: complexity-tests: remove ENABLE_{SRC_RANGE_CHECK, SESSION_AFFINITY}
9a29791 
#41238 raced against another
PR that introduced additional config files with these unused config
options. Clean it up.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@gandro gandro gandro approved these changes

@joamaki joamaki joamaki approved these changes

@joestringer joestringer joestringer approved these changes

@rgo3 rgo3 rgo3 approved these changes

@fristonio fristonio fristonio approved these changes

@thorn3r thorn3r Awaiting requested review from thorn3r thorn3r is a code owner automatically assigned from cilium/sig-agent

@asauber asauber Awaiting requested review from asauber asauber is a code owner automatically assigned from cilium/cli

@aditighag aditighag Awaiting requested review from aditighag aditighag is a code owner automatically assigned from cilium/sig-lb

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/agent Cilium agent related. area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
7 participants
@brb @derailed @gandro @joamaki @joestringer @rgo3 @fristonio