Remove EnableExternalIP and EnableHostPort #41277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
The --kube-proxy-replacement flag was previously a string with three
possible values: "disabled", "strict", and "partial". Since it now
accepts only two values ("true" and "false"), its type can be changed
to bool.
Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
Fun fact, it was no-op since v1.17. Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
|
/test |
joamaki
approved these changes
Aug 21, 2025
derailed
approved these changes
Aug 21, 2025
aspsk
approved these changes
Aug 22, 2025
sayboras
approved these changes
Aug 22, 2025
christarazi
approved these changes
Aug 22, 2025
marseel
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #39582
Removing
EnableNodePortis more involved due to BPF masq depending on it. Will do in a separate PR (incl. updating upgrade notes about the removal ofEnableExternalIPandEnableHostPort).