Skip to content

metrics: remove labels from client_rate_limiter #41247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

metrics: remove labels from client_rate_limiter #41247

merged 1 commit into from
Aug 19, 2025

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Aug 18, 2025 •
edited
Loading

Metric cilium_k8s_client_rate_limiter_duration_seconds is the metric with the highest cardinality. To reduce cardinality, let's remove path and method. These two labels are not really useful, as throttling is on client level and not per resource or verb.

metrics: cilium_k8s_client_rate_limiter_duration_seconds no longer has labels path and method

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 18, 2025
@marseel marseel added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Aug 19, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 19, 2025
@marseel
Copy link
Contributor Author

marseel commented Aug 19, 2025

/test

@marseel
metrics: remove labels from client_rate_limiter
61d4a21 
Metric cilium_k8s_client_rate_limiter_duration_seconds is the
metric with the highest cardinality. To reduce cardinality, let's remove
path and method. These two are not really useful, as throttling is on
client level and not per resource or verb.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the pr/marseel/improve_metrics branch from cfebb02 to 61d4a21 Compare August 19, 2025 10:53
@marseel
Copy link
Contributor Author

marseel commented Aug 19, 2025

/test

@marseel marseel marked this pull request as ready for review August 19, 2025 12:20
@marseel marseel requested review from a team as code owners August 19, 2025 12:20
@joestringer joestringer enabled auto-merge August 19, 2025 16:56
@joestringer joestringer added this pull request to the merge queue Aug 19, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 19, 2025
Merged via the queue into main with commit e2f6c06 Aug 19, 2025
367 of 369 checks passed
@joestringer joestringer deleted the pr/marseel/improve_metrics branch August 19, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@joestringer joestringer joestringer approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marseel @derailed @joestringer @tommyp1ckles