.github/workflows: add step 5 as part of the image build process #41113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
joestringer
reviewed
Aug 13, 2025
e3460a0 to
4036d47
Compare
|
/test |
4036d47 to
3a5dcde
Compare
|
/test |
joestringer
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
I'm a bit on the fence about whether this repository is the right place to host the logic for managing the merge, but on the other hand if it's part of this workflow which (a) has environment: release-tool for appropriate approvals and (b) is tied into the same workflow we already monitor for progress, it's probably easier to track the status of the release through this workflow than to add more logic elsewhere.
Either way this seems like an improvement to the process that should simplify things moving forward. If we hit some problems with this approach we can always amend the process further. 👍
brlbil
approved these changes
Aug 15, 2025
3a5dcde to
22703ac
Compare
This will make the release process even more smooth for release managers. Signed-off-by: André Martins <andre@cilium.io>
22703ac to
e9a0771
Compare
|
/test |
This was referenced Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the release process even more smooth for release managers.
Depends on cilium/release#348