fix(helm): add api-server-urls as flag to agent DS config initContainer #41110
Conversation
Pass the api-server-urls Helm value as a container args to the config initContainer of the cilium-agent DaemonSet. This will allow the config initContainer to hit apiserver correctly to build the rest of the config. Fixes cilium#41108 Signed-off-by: JJGadgets <git@jjgadgets.tech>
|
Requesting a review from @aditighag |
|
@gandro errrr so does it need a revision to the release note label...? The initial PR didn't have it, but I've since added it after seeing the bot label, so I'm not sure if it's fine as is, or it needs changes and you're just fighting the bot. |
I think there was some kind of race condition on GitHub's side. I think the GitHub UI re-added the "dont-merge" label when I added the "area/helm" label as I likely still the "dont-merge" label on the PR locally. I think everything should be fine now, since the bot corrected the superfluous label. |
|
/test |
|
@gandro @aditighag Is there a way to resolve the checks that are failing so the automerge goes through? I'm not sure how to continue from here. |
|
I've restarted them. They look like unrelated flakes |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Pass the api-server-urls Helm value as a container args to the config initContainer of the cilium-agent DaemonSet.
This will allow the config initContainer to hit apiserver correctly to build the rest of the config.
Fixes #41108