Skip to content

Helm: Only insert nodePort for cilium-ingress-service if specified #41107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

Helm: Only insert nodePort for cilium-ingress-service if specified #41107

merged 1 commit into from
Aug 19, 2025

Conversation

baurmatt
Copy link
Contributor

This is needed for ArgoCD deployments overwise the app will stay in OutOfSync status.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@baurmatt baurmatt requested review from a team as code owners August 13, 2025 09:47
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 13, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 13, 2025
@gandro gandro added release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Aug 13, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 13, 2025
@gandro
Copy link
Member

gandro commented Aug 13, 2025

/test

@gandro gandro enabled auto-merge August 13, 2025 09:50
@gandro
Copy link
Member

gandro commented Aug 19, 2025

CI is failing because the branch is very old and there's a discrepancy between the tests and the tested code. Unfortunately I don't have permissions to rebase it myself. @baurmatt could you rebase on current main so we can re-run CI? Thanks.

@baurmatt
Only insert nodePort for cilium-ingress-service if specified
ea71d88 
This is needed for ArgoCD deployments overwise the app will stay in
OutOfSync status.

Signed-off-by: Matthias Baur <m.baur@syseleven.de>
auto-merge was automatically disabled August 19, 2025 08:22

Head branch was pushed to by a user without write access

@gandro
Copy link
Member

gandro commented Aug 19, 2025

/test

@gandro gandro enabled auto-merge August 19, 2025 08:25
@baurmatt
Copy link
Contributor Author

@baurmatt Doesn't seem to help :( Kind of doubt that the broken CI is related to my change 🙈

@gandro
Copy link
Member

gandro commented Aug 19, 2025

The failures are different now - they look still unrelated though, I'll restart.

@gandro gandro added this pull request to the merge queue Aug 19, 2025
Merged via the queue into cilium:main with commit 3dcb8d9 Aug 19, 2025
68 checks passed
@joamaki joamaki mentioned this pull request Aug 19, 2025
Merged
19 tasks
@joamaki joamaki added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Aug 19, 2025
@github-actions github-actions bot added backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baurmatt @gandro @joamaki