Skip to content

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Aug 15, 2025

As a follow-up to an update in our sphinx_rtd_theme fork where we added support for a dark theme for the docs website, make our requirements.txt point to the new branch tip to pull the newest version of our theme.

Credits go to @UtkarshSiddhpura, and to authors of the Sphinx theme add-on he drew inspiration from, for the dark theme.

Fixes: #31391
Link: cilium/sphinx_rtd_theme#26

(Repost from #41172)

As a follow-up to an update in our sphinx_rtd_theme fork where we added
support for an opt-in dark version of the theme for the docs website,
make our requirements.txt point to the new branch tip to pull the newest
version of our theme.

Credits go to Utkarsh, and to authors of the Sphinx theme add-on he drew
inspiration from, for the dark theme.

Fixes: #31391
Link: cilium/sphinx_rtd_theme#26
Co-authored-by: UtkarshSiddhpura <utkarshsiddhpura09876@gmail.com>
Signed-off-by: Quentin Monnet <qmo@qmon.net>
@qmonnet qmonnet requested review from hemanthmalla, xmulligan and a team August 15, 2025 10:13
@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Aug 15, 2025
@qmonnet qmonnet requested a review from a team as a code owner August 15, 2025 10:13
@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Aug 15, 2025
Signed-off-by: Quentin Monnet <qmo@qmon.net>
@qmonnet
Copy link
Member Author

qmonnet commented Aug 15, 2025

Hmm because the deployment already generated the new image on top of the same commit on the first PR, it won't automatically add the workflow update on this one, either. Never mind, I'll just update manually.

@qmonnet qmonnet requested review from a team as code owners August 15, 2025 10:37
@qmonnet qmonnet requested a review from Artyop August 15, 2025 10:37
@qmonnet qmonnet deployed to docs-builder August 15, 2025 10:37 — with GitHub Actions Active
@qmonnet
Copy link
Member Author

qmonnet commented Aug 15, 2025

/test

Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the hash super carefully

@qmonnet
Copy link
Member Author

qmonnet commented Aug 15, 2025

Thank you, Tam! 😄

@qmonnet qmonnet enabled auto-merge August 15, 2025 16:58
@qmonnet qmonnet added this pull request to the merge queue Aug 20, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 20, 2025
Merged via the queue into main with commit 555416c Aug 20, 2025
77 checks passed
@qmonnet qmonnet deleted the pr/qmonnet/docs-dark-theme branch August 20, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFP: Dark Mode in Documentations
5 participants