-
Notifications
You must be signed in to change notification settings - Fork 3.4k
docs: Update theme to add dark mode support #41174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a follow-up to an update in our sphinx_rtd_theme fork where we added support for an opt-in dark version of the theme for the docs website, make our requirements.txt point to the new branch tip to pull the newest version of our theme. Credits go to Utkarsh, and to authors of the Sphinx theme add-on he drew inspiration from, for the dark theme. Fixes: #31391 Link: cilium/sphinx_rtd_theme#26 Co-authored-by: UtkarshSiddhpura <utkarshsiddhpura09876@gmail.com> Signed-off-by: Quentin Monnet <qmo@qmon.net>
xmulligan
approved these changes
Aug 15, 2025
Signed-off-by: Quentin Monnet <qmo@qmon.net>
Hmm because the deployment already generated the new image on top of the same commit on the first PR, it won't automatically add the workflow update on this one, either. Never mind, I'll just update manually. |
/test |
sayboras
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the hash super carefully
Thank you, Tam! 😄 |
hemanthmalla
approved these changes
Aug 19, 2025
Artyop
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to an update in our sphinx_rtd_theme fork where we added support for a dark theme for the docs website, make our requirements.txt point to the new branch tip to pull the newest version of our theme.
Credits go to @UtkarshSiddhpura, and to authors of the Sphinx theme add-on he drew inspiration from, for the dark theme.
Fixes: #31391
Link: cilium/sphinx_rtd_theme#26
(Repost from #41172)