kvstore: fix overly verbose debug log and error message #41148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
aanm
approved these changes
Aug 15, 2025
The debug message in the [UpsertKey] function used to pass the entire key object as logfield, possibly leading to a very verbose and/or fairly useless output (especially when the value is a byte slice). Let's get this fixed by only passing the key name (i.e., part of the key in etcd) as logfield, similarly to what already done in the other functions. And likewise for the error message in the same function, even though never expected to be triggered. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
5ef8fba to
0d3f1bf
Compare
|
Rebased onto main, let's see if CI is happier. |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug message in the [UpsertKey] function used to pass the entire key object as logfield, possibly leading to a very verbose and/or fairly useless output (especially when the value is a byte slice). Let's get this fixed by only passing the key name (i.e., part of the key in etcd) as logfield, similarly to what already done in the other functions. And likewise for the error message in the same function, even though never expected to be triggered.