bpf/tests: add coverage for bpf icmp nodeport snat tests. #41142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICMP PMTU response datapath logic is somewhat unique in that it depends in parsing encapsulated l4 headers after the icmp header. This PR expands the coverage for logic covering the scenario of This is prone to regressions as the functionality may not be regularly exercised by normal e2e tests. Using this, we create three new test files to prevent regression on several env configuration tuples: * tunnel=false hostfw=false * tunnel=false hostfw=true * tunnel=true hostfw=false Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
639f3cf to
d4ac75a
Compare
|
/test |
YutaroHayakawa
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICMP PMTU response datapath logic is somewhat unique in that it depends in parsing encapsulated l4 headers after the icmp header. This PR expands the coverage for logic covering the scenario of
This is prone to regressions as the functionality may not be regularly exercised by normal e2e tests.
Using this, we create three new test files to prevent regression on several env configuration tuples: