Skip to content

Conversation

joestringer
Copy link
Member

One of these was for GKE v1.15 which is ancient, but all of the other
references to v1.15 are for Cilium and are also stale. Remove them.

One of these was for _GKE_ v1.15 which is ancient, but all of the other
references to v1.15 are for Cilium and are also stale. Remove them.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested a review from a team as a code owner August 8, 2025 16:25
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Aug 8, 2025
@joestringer joestringer requested a review from a team as a code owner August 8, 2025 16:25
@joestringer joestringer added the needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch label Aug 8, 2025
@joestringer joestringer requested review from a team as code owners August 8, 2025 16:25
@joestringer
Copy link
Member Author

cc at least @YutaroHayakawa @squeed who I saw authored some of these warnings. I sometimes notice statements like this when they are proposed into the tree and I recognize that they create minor tech debt for a subsequent release. The owners for the specific docs are unlikely to revisit the docs to remove these old references. Not sure if it's better to avoid documenting this stuff if we know the information will be stale in a few months, or better to document and accept that sometimes the docs just get overgrown with stale info. 🤔

@joestringer joestringer enabled auto-merge August 8, 2025 17:59
@joestringer
Copy link
Member Author

/test

@joestringer joestringer added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit c697c7e Aug 11, 2025
83 checks passed
@joestringer joestringer deleted the pr/joe/remove-old-warning branch August 11, 2025 16:11
@YutaroHayakawa YutaroHayakawa mentioned this pull request Aug 11, 2025
10 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Aug 11, 2025
@YutaroHayakawa
Copy link
Member

cc at least @YutaroHayakawa @squeed who I saw authored some of these warnings. I sometimes notice statements like this when they are proposed into the tree and I recognize that they create minor tech debt for a subsequent release. The owners for the specific docs are unlikely to revisit the docs to remove these old references. Not sure if it's better to avoid documenting this stuff if we know the information will be stale in a few months, or better to document and accept that sometimes the docs just get overgrown with stale info. 🤔

Yeah, in this specific issue, I could expect that the issue will be solved in a few months, so could avoid documentation. The actual problem is already described well in the linked GH issue, so this document was solely introduced to letting users notice there's a known issue before they use the feature. Otherwise, we need to rely on users to check the GH issues to discover the known issue. I'm not sure how much of our users have a habit to check the GH issue before enabling the feature.

On the other hand, it is too easy for developers to forget about this kind of the doc (like I did). I don't really come up with a better way to avoid that mistake with relying on the author's memory.

@joestringer
Copy link
Member Author

Maybe this is one of those things we just state, as long as there's a version number and you include that version number in the to-be-stale content, at least we can grep for older version numbers a couple of times a year and clean them up. Maybe we don't need anything more elaborate than that. I found these somehow, right?

@github-actions github-actions bot added backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants