loadbalancer: Fix topology-aware routing safe-guards #41024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cilium's topology-aware implementation did not correctly implement the following safe guards [1]: 4. If no fitting backend found for current zone us backends from all zones 5. Use all backends if one or more endpoints did not have zone hints It did correctly implement: (1. insufficient endpoints (endpointslice controller responsibility) (2. unbalanced allocation (endpointslice controller responsibility) 3. Use all backends if local node missing zone label This is fixed by doing an additional iteration over the backends to check 4. and 5. before trying to apply the zone hints. [1]: https://kubernetes.io/docs/concepts/services-networking/topology-aware-routing/#enabling-topology-aware-routing. Fixes: e35c099 ("experimental: Implement support for topology-aware routing") Fixes: cilium#41022 Signed-off-by: Jussi Maki <jussi@isovalent.com>
3 tasks
|
/test |
10 tasks
|
@joamaki FYI this PR has not been backported to v1.18 even tho it has the needs-backport/1.18 label. |
|
Looks like the backport happened here: #41116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cilium's topology-aware implementation did not correctly implement the following safe guards 1:
It did correctly implement:
(1. insufficient endpoints (endpointslice controller responsibility)
(2. unbalanced allocation (endpointslice controller responsibility)
3. Use all backends if local node missing zone label
This is fixed by doing an additional iteration over the backends to check
4. and 5. before trying to apply the zone hints.
Fixes: e35c099 ("experimental: Implement support for topology-aware routing")
Fixes: #41022