Skip to content

Log whether CES is enabled in CID controller #41023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

Log whether CES is enabled in CID controller #41023

merged 1 commit into from
Sep 1, 2025

Conversation

kamilWyszynski1
Copy link
Contributor

Log whether CES is enabled in CID controller for better observability.

@kamilWyszynski1 kamilWyszynski1 requested a review from a team as a code owner August 8, 2025 11:20
@kamilWyszynski1 kamilWyszynski1 requested a review from joamaki August 8, 2025 11:20
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 8, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 8, 2025
@kamilWyszynski1 kamilWyszynski1 force-pushed the pr/CID-controller-start-log branch from 9a81779 to fdc080a Compare August 8, 2025 12:31
@kamilWyszynski1 kamilWyszynski1 requested a review from a team as a code owner August 8, 2025 12:31
@joamaki
Copy link
Contributor

joamaki commented Aug 11, 2025

/test

@kamilWyszynski1
Copy link
Contributor Author

Hi @joamaki

could you restart the CI tests? I suppose these are flaky ones, not really related to my small change :)

@joamaki
Copy link
Contributor

joamaki commented Aug 15, 2025

/test

If they still flake out on this run please rebase as there were some fixes.

@joamaki
Copy link
Contributor

joamaki commented Aug 15, 2025

/test

@maintainer-s-little-helper
Copy link

Commit 9bf19ab does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 18, 2025
@kamilWyszynski1 kamilWyszynski1 force-pushed the pr/CID-controller-start-log branch from 9bf19ab to 34f134d Compare August 18, 2025 11:23
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 18, 2025
@kamilWyszynski1
Copy link
Contributor Author

Hi @joamaki

could you delete dont-merge/needs-release-note-label label? It was added automatically, but I reckon that it's not needed in that case - Mergeability check fails because of that

Thanks!

@kamilWyszynski1 kamilWyszynski1 force-pushed the pr/CID-controller-start-log branch from 34f134d to d73ddf2 Compare August 21, 2025 12:59
@marseel marseel added the release-note/misc This PR makes changes that have no direct user impact. label Aug 25, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 25, 2025
@marseel
Copy link
Contributor

marseel commented Aug 25, 2025

/test

@kamilWyszynski1 kamilWyszynski1 force-pushed the pr/CID-controller-start-log branch from d73ddf2 to 3afe78d Compare August 28, 2025 11:07
@kamilWyszynski1
Log whether CES is enabled in CID controller
d338918 
Signed-off-by: Kamil Wyszyński <kwyszynski@google.com>
@kamilWyszynski1 kamilWyszynski1 force-pushed the pr/CID-controller-start-log branch from 3afe78d to d338918 Compare September 1, 2025 10:02
@tsotne95
Copy link
Contributor

tsotne95 commented Sep 1, 2025

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 1, 2025
@marseel marseel added this pull request to the merge queue Sep 1, 2025
Merged via the queue into cilium:main with commit 1eef389 Sep 1, 2025
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamilWyszynski1 @joamaki @marseel @tsotne95