Skip to content

helm: Support extending cilium-agent dnsPolicy as downstream packager #41010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

helm: Support extending cilium-agent dnsPolicy as downstream packager #41010

merged 1 commit into from
Aug 15, 2025

Conversation

devodev
Copy link
Contributor

@devodev devodev commented Aug 7, 2025

We want to repackage the cilium chart and set the dnsPolicy programmatically based on additional helm values and templates.

Add a new extension template: cilium-agent.dnsPolicy that is included in the cilium-agent daemonset and can be overridden by downstream packagers with custom handling.

Support extending cilium-agent dnsPolicy as a downstream packager

@devodev devodev requested review from a team as code owners August 7, 2025 19:02
@devodev devodev requested review from joamaki and brlbil August 7, 2025 19:02
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 7, 2025
brlbil
brlbil approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devodev you need to fix commit message to pass BPF Check, otherwise 👍

@devodev devodev force-pushed the pr/devodev/helm-cilium-agent-dnspolicy-extension branch from a94ce95 to 813db14 Compare August 11, 2025 14:23
@devodev
Copy link
Contributor Author

devodev commented Aug 11, 2025

/test

@devodev
Copy link
Contributor Author

devodev commented Aug 11, 2025

Forgot to mention, could we add backport labels for 1.17 and 1.18? Thanks!

@brlbil brlbil added the release-note/misc This PR makes changes that have no direct user impact. label Aug 12, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 12, 2025
@brlbil brlbil added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. labels Aug 12, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 12, 2025
@aanm aanm added needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch and removed backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. labels Aug 13, 2025
@devodev devodev force-pushed the pr/devodev/helm-cilium-agent-dnspolicy-extension branch from 813db14 to 756efd0 Compare August 13, 2025 20:29
@devodev
Copy link
Contributor Author

devodev commented Aug 13, 2025

/test

@devodev
helm: Support extending cilium-agent dnsPolicy as downstream packager
d4a3174 
We want to repackage the cilium chart and set the dnsPolicy
programmatically based on additional helm values and templates.

Add a new extension template: cilium-agent.dnsPolicy that is included
in the cilium-agent daemonset and can be overridden by downstream
packagers with custom handling.

Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
@devodev devodev force-pushed the pr/devodev/helm-cilium-agent-dnspolicy-extension branch from 756efd0 to d4a3174 Compare August 14, 2025 13:28
@devodev
Copy link
Contributor Author

devodev commented Aug 14, 2025

/test

@devodev
Copy link
Contributor Author

devodev commented Aug 14, 2025

/ci-clustermesh

@devodev
Copy link
Contributor Author

devodev commented Aug 14, 2025

/ci-gateway-api

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 14, 2025
@rolinh rolinh added this pull request to the merge queue Aug 15, 2025
Merged via the queue into cilium:main with commit 8aceb53 Aug 15, 2025
68 checks passed
@joamaki joamaki mentioned this pull request Aug 19, 2025
Merged
2 tasks
@joamaki joamaki added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Aug 19, 2025
@joamaki joamaki mentioned this pull request Aug 19, 2025
Merged
19 tasks
@joamaki joamaki added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Aug 19, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

@brlbil brlbil brlbil approved these changes

Assignees
No one assigned
Labels
backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devodev @joamaki @brlbil @rolinh @aanm