Skip to content

Conversation

aanm
Copy link
Member

@aanm aanm commented Aug 7, 2025

Some features can be presented as metrics. Namely:
Kernel version
Strict encryption mode
Endpoint Routes
K8s version.

While, not as metrics but as cluster status, were added to the cilium-cli feature summary:
NodeLocalDNS
KubeProxy

Add `kernel_version`, `endpoint_routes_enabled`, `strict_mode_enabled` and `kubernetes_version` feature metrics.

@aanm aanm requested review from a team as code owners August 7, 2025 13:40
@aanm aanm added the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Aug 7, 2025
@aanm aanm requested a review from bimmlerd August 7, 2025 13:40
@aanm aanm added needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Aug 7, 2025
@aanm aanm requested a review from derailed August 7, 2025 13:40
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 7, 2025
@github-actions github-actions bot added the cilium-cli This PR contains changes related with cilium-cli label Aug 7, 2025
@aanm aanm added area/CI Continuous Integration testing issue or flake area/metrics Impacts statistics / metrics gathering, eg via Prometheus. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. cilium-cli This PR contains changes related with cilium-cli labels Aug 7, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 7, 2025
@aanm aanm enabled auto-merge August 7, 2025 13:41
@aanm aanm added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Aug 7, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 7, 2025
@aanm
Copy link
Member Author

aanm commented Aug 7, 2025

/test

@aanm aanm force-pushed the pr/add-missing-features branch from 260156c to 6bb4f6b Compare August 7, 2025 13:55
@aanm aanm requested review from a team as code owners August 7, 2025 13:55
@aanm aanm requested a review from brlbil August 7, 2025 13:55
@aanm aanm marked this pull request as draft August 7, 2025 13:59
auto-merge was automatically disabled August 7, 2025 13:59

Pull request was converted to draft

@aanm aanm force-pushed the pr/add-missing-features branch from 6bb4f6b to dc6b5e9 Compare August 7, 2025 14:10
@aanm aanm force-pushed the pr/add-missing-features branch from dc6b5e9 to 7325b93 Compare August 7, 2025 15:50
@aanm
Copy link
Member Author

aanm commented Aug 7, 2025

/test

@aanm aanm marked this pull request as ready for review August 7, 2025 15:57
aanm added 5 commits August 8, 2025 10:37
Signed-off-by: André Martins <andre@cilium.io>
In some cases, the kernel version detection was not working. This commit
fixes these bugs and add the tests for the missing cases.

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
Skip label value checks in checkLabels and checkLabelValues when the
allowed values set is empty, allowing unrestricted values for those labels.

Fixes: 6659745 ("metric: provide way to declare labels.")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/add-missing-features branch from 2f25b05 to 76fa5a6 Compare August 8, 2025 08:37
@aanm
Copy link
Member Author

aanm commented Aug 8, 2025

/test

Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aanm Nice work!

@aanm aanm added this pull request to the merge queue Aug 9, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 9, 2025
Merged via the queue into main with commit 1077bde Aug 9, 2025
319 of 325 checks passed
@aanm aanm deleted the pr/add-missing-features branch August 9, 2025 05:17
@YutaroHayakawa YutaroHayakawa mentioned this pull request Aug 11, 2025
2 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Aug 11, 2025
@YutaroHayakawa YutaroHayakawa mentioned this pull request Aug 11, 2025
3 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Aug 11, 2025
@YutaroHayakawa YutaroHayakawa mentioned this pull request Aug 11, 2025
10 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Aug 11, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/metrics Impacts statistics / metrics gathering, eg via Prometheus. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants