-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add missing feature metrics #41003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add missing feature metrics #41003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
260156c
to
6bb4f6b
Compare
auto-merge was automatically disabled
August 7, 2025 13:59
Pull request was converted to draft
6bb4f6b
to
dc6b5e9
Compare
bimmlerd
approved these changes
Aug 7, 2025
dc6b5e9
to
7325b93
Compare
/test |
Signed-off-by: André Martins <andre@cilium.io>
In some cases, the kernel version detection was not working. This commit fixes these bugs and add the tests for the missing cases. Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
Skip label value checks in checkLabels and checkLabelValues when the allowed values set is empty, allowing unrestricted values for those labels. Fixes: 6659745 ("metric: provide way to declare labels.") Signed-off-by: André Martins <andre@cilium.io>
2f25b05
to
76fa5a6
Compare
/test |
derailed
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aanm Nice work!
tommyp1ckles
approved these changes
Aug 8, 2025
2 tasks
3 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
area/metrics
Impacts statistics / metrics gathering, eg via Prometheus.
backport-done/1.16
The backport for Cilium 1.16.x for this PR is done.
backport-done/1.17
The backport for Cilium 1.17.x for this PR is done.
backport-done/1.18
The backport for Cilium 1.18.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some features can be presented as metrics. Namely:
Kernel version
Strict encryption mode
Endpoint Routes
K8s version.
While, not as metrics but as cluster status, were added to the
cilium-cli feature summary
:NodeLocalDNS
KubeProxy