bpf/tests: port L2 IPv6 announce to scapy and some cleanups #41071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
YutaroHayakawa
approved these changes
Aug 11, 2025
a61647e to
8a0e20d
Compare
|
Rebased on top of main and #41017 |
|
/test |
8a0e20d to
3ff9aeb
Compare
This commit adapts tc_l2_announce6.c to scapy. Signed-off-by: Marc Suñé <marc.sune@isovalent.com>
This commit: * Makes pkt_defs.py more readable by adjusting to max 80cols. Signed-off-by: Marc Suñé <marc.sune@isovalent.com>
This commit: * Refactors pkt_defs.h to use scapy utilities to calculate the neighbour Solicited-Node Address for the target v6 address and use it as IPv6 target address (as well-formed NS packets should). * It also makes sure the LLSRC matches the SRC address of the pkt, which technically is not necessarily true (e.g. with proxies) but it's the common use-case. Signed-off-by: Marc Suñé <marc.sune@isovalent.com>
This commit adds BPF unit test coverage for targeted IPv6 NSs on the L2 announce IPv6 support. Signed-off-by: Marc Suñé <marc.sune@isovalent.com>
3ff9aeb to
1099745
Compare
|
/test |
|
🟢 Ready to merge. No release note. |
|
4 days in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset:
tc_l2_announce6.cusing scapy buffers.tc_l2_announce6.c. Also makes untargeted NSs use IPv6 solicited node address.bpf/tests/scapy/pkt_defs.pyPlease note this PR builds on top #41017, so this PR can't be merged before #41017.