Add reusable test config workflow #40935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
e71b7ca to
d5d9729
Compare
|
/test |
d5d9729 to
855fe9b
Compare
|
/test |
855fe9b to
58f83d3
Compare
|
/test |
58f83d3 to
bb22d6e
Compare
|
/test |
mhofstetter
approved these changes
Aug 7, 2025
This test configuration reusable action will allow us to centralize many of the common flags passed to the Cilium CLI as part of running tests via 'cilium connectivity test ...'. Signed-off-by: Joe Stringer <joe@cilium.io>
While we're at it, consolidate the external CIDR usage onto the default defined in the cli-test-config rather than specifically using CloudFlare IPs for external targets in these tests. Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
This test didn't seem to declare or use any default parameters. Switch it to use the same style as the recent commits so that we can deduplicate the common configuration between cli-test-config and conn-disrupt-check. Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
IPsec upgrade test didn't seem to declare or use any default parameters. Switch it to use the same style as the recent commits so that we can deduplicate the common configuration between cli-test-config and conn-disrupt-test-check. While we're at it, ensure the other conn-disrupt-test-check invocations also consistently use the flags. Signed-off-by: Joe Stringer <joe@cilium.io>
This test runs in kind in Microsoft GitHub infrastructure, so it should be more reliable pinging to other Microsoft properties (ie use the default settings in the cli-test-config reusable workflow). Signed-off-by: Joe Stringer <joe@cilium.io>
The users of conn-disrupt-test-check all use cli-test-config which already specifies these parameters. Remove the duplicate parameters here. Technically test-concurrency is also one of these duplicated flags, but it's optional for the cli-test-config and if unspecified it will defer to the CLI binary default. Since the workflows that invoke conn-disrupt-test-check often choose concurrency or not in the test selection parameters, leave that parameter alone. Signed-off-by: Joe Stringer <joe@cilium.io>
bb22d6e to
d6049f8
Compare
|
/test |
tamilmani1989
approved these changes
Aug 12, 2025
brlbil
approved these changes
Aug 13, 2025
ldelossa
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'cli-test-config', a reusable workflow for defining the flags to pass to
Cilium connectivity tests which should allow the tests to more consistently
pass the common flags (like parameters for code owners, sysdumps, timeouts).
This enables much easier extension of testing flags to apply CI-wide, like in #40957 .
The goal for this PR is just to centralize the configuration, but I could
imagine future PRs taking this further to centralize all of the CLI test runs
across both conn-disrupt-test and regular test runs. I've left that out of
scope for this PR as the main goal I want to achieve is #40957.