endpoint: Avoid unnecessarily logging a warning during endpoint deletion #40927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
Not sure whether v1.18 is affected by this or not to mark for v1.18 backport - I saw this failure condition for the first time today. I just don't know whether we saw it now because we changed something about startup ordering or if it's always been possible and it's just rare enough we don't often see it. |
|
I'm OK with backporting this as it's just changing the logging for this condition. |
joestringer
reviewed
Aug 4, 2025
7536c06 to
6d4893c
Compare
It is possible during endpoint restoration for the endpoint to be deleted in the middle of the process. If the endpoint restoration process was waiting for global identities to be synced and the deletion occurs, then the wait for the sync will be canceled. This triggers an unnecessary warning log. To fix, detect that the endpoint is deleted which we can tell by checking if the context was canceled. See cilium#40924 for more details. Fixes: cilium#40924 Signed-off-by: Joe Stringer <joe@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
6d4893c to
d0f8767
Compare
|
/test Edit: #39370 |
fristonio
approved these changes
Aug 5, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible during endpoint restoration for the endpoint to be
deleted in the middle of the process. If the endpoint restoration
process was waiting for global identities to be synced and the deletion
occurs, then the wait for the sync will be canceled. This triggers an
unnecessary warning log. To fix, detect that the endpoint is deleted
which we can tell by checking if the context was canceled.
See #40924 for more details.
Fixes: #40924
Signed-off-by: Joe Stringer joe@cilium.io
Signed-off-by: Chris Tarazi chris@isovalent.com