Makefile: Fix multi codeowner detection #40923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when multiple code owners were specified, the extra files would be passed as separate arguments, but the subsequent commands expect them to be specified in the form "file1,file2". Emit them as comma-separated values instead of space-separated. Fixes: dda3976 ("Fix code owner attribution for test failures on stable branches") Signed-off-by: Joe Stringer <joe@cilium.io>
14 tasks
|
/test |
8 tasks
HadrienPatte
approved these changes
Aug 4, 2025
|
Hit #39370 in ci-clustermesh twice. Retriggering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when multiple code owners were specified, the extra files
would be passed as separate arguments, but the subsequent commands
expect them to be specified in the form "file1,file2". Emit them as
comma-separated values instead of space-separated.
Fixes: dda3976 ("Fix code owner attribution for test failures on stable branches")
Fixes: #40776
Related: #40847