Skip to content

ci: regex update variable runners #40921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

ci: regex update variable runners #40921

merged 1 commit into from
Aug 5, 2025

Conversation

Artyop
Copy link
Contributor

@Artyop Artyop commented Aug 4, 2025

In this commit we add a regex to update github runner labels that are substituted if a github var isn't defined.
Example : runs-on: ${{ vars.GH_RUNNER_EXTRA_POWER_UBUNTU_LATEST || 'ubuntu-24.04' }}
Not covered by default through renovate base config cf https://docs.renovatebot.com/modules/manager/github-actions/#non-support-of-variables

Local logs (after downgrading runner for build-images-ci.yaml) :

"deps": [
 {
   "depName": "ubuntu",
   "packageName": "ubuntu",
   "currentValue": "22.04",
   "datasource": "github-runners",
   "replaceString": "'ubuntu-22.04'",
   "updates": [
     {
       "bucket": "latest",
       "newVersion": "24.04",
       "newValue": "24.04",
       "newMajor": 24,
       "newMinor": 4,
       "newPatch": null,
       "updateType": "major",
       "isBreaking": true,
       "branchName": "renovate/all-github-action"
     }
   ],
   "versioning": "docker",
   "warnings": [],
   "sourceUrl": "https://github.com/actions/runner-images",
   "currentVersion": "22.04",
   "isSingleVersion": true,
   "fixedVersion": "22.04"
 }
],
"matchStrings": ["['\"]ubuntu-(?<currentValue>[0-9]{2}\\.[0-9]{2})['\"]"],
"depNameTemplate": "ubuntu",
"packageNameTemplate": "ubuntu",
"datasourceTemplate": "github-runners",
"packageFile": ".github/workflows/build-images-ci.yaml"
},

@Artyop
ci: regex update variable runners
9b77fac 
In this commit we add a regex to update github runner labels that are substituted if a github var isn't defined.
Example : `runs-on: ${{ vars.GH_RUNNER_EXTRA_POWER_UBUNTU_LATEST || 'ubuntu-24.04' }}``
Not covered by default through renovate base config cf https://docs.renovatebot.com/modules/manager/github-actions/#non-support-of-variables

Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 4, 2025
@Artyop Artyop added the release-note/misc This PR makes changes that have no direct user impact. label Aug 4, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 4, 2025
@Artyop Artyop marked this pull request as ready for review August 4, 2025 16:04
@Artyop Artyop requested review from a team as code owners August 4, 2025 16:04
@Artyop Artyop requested a review from brlbil August 4, 2025 16:04
@Artyop
Copy link
Contributor Author

Artyop commented Aug 4, 2025

@aanm FYI we talked about this privately

@Artyop
Copy link
Contributor Author

Artyop commented Aug 4, 2025

/test

@aanm aanm added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit a7c7d26 Aug 5, 2025
77 checks passed
@aanm aanm deleted the pr/artyop/renovate-runner-variable-update branch August 5, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@brlbil brlbil Awaiting requested review from brlbil brlbil is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Artyop @aanm