Skip to content

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented Aug 4, 2025

The "statedb" command was deprecated in favor of the "db/show" commands in shell. Since we still need a separate full StateDB dump command, repurpose the "statedb" command for the dump instead of removing or hiding it.

@joamaki joamaki requested a review from a team as a code owner August 4, 2025 08:35
@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label Aug 4, 2025
@joamaki joamaki requested a review from asauber August 4, 2025 08:35
@joamaki joamaki force-pushed the pr/joamaki/remove-cilium-dbg-statedb-command branch from 4d9a8ad to 756abb0 Compare August 5, 2025 11:04
@joamaki joamaki force-pushed the pr/joamaki/remove-cilium-dbg-statedb-command branch from 756abb0 to dd474a6 Compare August 8, 2025 13:52
@joamaki
Copy link
Contributor Author

joamaki commented Aug 8, 2025

/test

@joamaki joamaki enabled auto-merge August 8, 2025 13:53
The "statedb" command was deprecated in favor of the "db/show" commands
in shell. Since we still need a separate full StateDB dump command,
repurpose the "statedb" command for the dump instead of removing or
hiding it.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki force-pushed the pr/joamaki/remove-cilium-dbg-statedb-command branch from dd474a6 to a93b211 Compare August 8, 2025 14:00
@joamaki joamaki requested a review from a team as a code owner August 8, 2025 14:00
@joamaki joamaki requested a review from qmonnet August 8, 2025 14:00
@joamaki
Copy link
Contributor Author

joamaki commented Aug 11, 2025

/test

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@joamaki joamaki added this pull request to the merge queue Aug 11, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 11, 2025
Merged via the queue into cilium:main with commit 21bd6a1 Aug 11, 2025
72 checks passed
@joamaki joamaki deleted the pr/joamaki/remove-cilium-dbg-statedb-command branch August 11, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants