Skip to content

renovate: Fix go-github exclusion rule #40911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

Conversation

HadrienPatte
Copy link
Member

This week's renovate update (#40897) tried and failed to upgrade google/go-github because of how this module's major version is included in the module import path.

Automated major upgrades for this module were supposed to be disabled by #40326, but that PR did not actually work as expected as it configured github.com/google/go-github in matchPackageNames which only does an exact module name match and does not match the actual module name which includes the module major version.

This PR fixes the logic by configuring this matchPackageNames with a glob pattern.

Relevant renovate documentations on exact string matches, glob patterns and regex in matchPackageNames: https://docs.renovatebot.com/string-pattern-matching/

Note: for a followup, instead of disabling major upgrades for this module, we could consider instead configuring renovate with a postUpgradeTasks to sed the module import string to use the new major version.


Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
renovate: Fix go-github exclusion rule

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 3, 2025
@HadrienPatte
Copy link
Member Author

/test

@HadrienPatte HadrienPatte marked this pull request as ready for review August 3, 2025 15:35
@HadrienPatte HadrienPatte requested review from a team as code owners August 3, 2025 15:35
@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 4, 2025
@aanm aanm added this pull request to the merge queue Aug 4, 2025
Merged via the queue into main with commit 8794c54 Aug 4, 2025
79 checks passed
@aanm aanm deleted the pr/HadrienPatte/go-github branch August 4, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants