loadbalancer: Raise default retry duration to 1 second #40997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 50ms minimum retry leads to very high load if there are many entries that do not fit into the LB BPF maps. Since the probability of a BPF syscall failing without maps being full is very unlikely, raise default to 1 second to avoid excessive load in situations where BPF maps overflow. Signed-off-by: Jussi Maki <jussi@isovalent.com>
|
/test |
aditighag
approved these changes
Aug 7, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 50ms minimum retry leads to very high load if there are many entries that do not fit into the LB BPF maps.
Since the probability of a BPF syscall failing without maps being full is very unlikely, raise default to 1 second to avoid excessive load in situations where BPF maps overflow.
This was found during benchmarking when I accidentally added ~150000 backends, so 90k more than fit in the map. If there's only few entries that overflow than even with the 50ms minimum retry the load is minimal, so it's more of a "fix for extremes". Marking for backport to v1.18 as this is still useful to change.