cni: Avoid lockfile leak on context timeout #40958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If locking a newly created lockfile ever blocked for an extended period, this code would technically not close the corresponding file. Given that the lockfile was just created this seems highly unlikely, but we may as well make the logic right anyway. Found by inspection. Signed-off-by: Joe Stringer <joe@cilium.io>
|
/test |
fristonio
approved these changes
Aug 5, 2025
joamaki
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If locking a newly created lockfile ever blocked for an extended period,
this code would technically not close the corresponding file. Given that
the lockfile was just created this seems highly unlikely, but we may as
well make the logic right anyway.
Found by inspection.