shell: don't reconnect on connection close #40950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some people just want to exit their shell. The server has code for exit/stop/quit - but all it does is closing the connection. However, the client immediately reconnected on connection close, so that did nothing. But reconnecting on connection close isn't really necessary: this is a local connection, so it seems unlikely to break. Hence, take the closing as a hint to stop. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
|
/test |
|
The other option would be to make https://github.com/cilium/cilium/blob/main/pkg/shell/server/shell_server.go#L148 a bit smarter and send down some explicit quit signal Other a third would be to handle exit/etc locally. I don't really have a preference |
|
CI: |
joamaki
requested changes
Aug 6, 2025
joamaki
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people just want to exit their shell. The server has code for exit/stop/quit - but all it does is closing the connection. However, the client immediately reconnected on connection close, so that did nothing.
But reconnecting on connection close isn't really necessary: this is a local connection, so it seems unlikely to break. Hence, take the closing as a hint to stop.
Note to review: the diff looks horrible but all I did was drop a for loop 😅 You probably want to click that Hide whitespace button in the review.