Don't enable host firewall bypass unless host firewall is enabled #40942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Tykhyy <atykhyy@gmail.com>
|
/test |
|
For what it's worth, the failure in |
joamaki
approved these changes
Aug 6, 2025
|
FWIW for future reference it's easier for committers to understand the status of the PR if CI results are reported with issue links (related: CI Failure Triage Docs). Example:
Given these issues have been reported by others, I think it's fair to say this PR is not introducing these failures. |
joestringer
reviewed
Aug 20, 2025
|
This seems ready to merge. Thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An analysis of e2e conformance test failures reported in #40682 and attributed to #40346 (k8s host firewall bypass) being enabled by default showed that these failures appear in test jobs where IPSec is enabled. However, IPSec cannot be used with the host firewall, whereas the whole host (node) FQDN-based egress rules feature, which creates the need for a bypass, only makes sense with the host firewall. This PR ensures that the bypass is not enabled unless the host firewall is enabled.
Fixes: #40682
Related: #40346