Skip to content

docs: enable debug information before first authentication in mutual auth example #40940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

docs: enable debug information before first authentication in mutual auth example #40940

merged 1 commit into from
Aug 20, 2025

Conversation

sudeephb
Copy link
Contributor

@sudeephb sudeephb commented Aug 5, 2025

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

In the Mutual Authentication Example page, enabling debug logs after running curl commands doesn't show the authentication flow in the debug logs when inspecting the logs afterwards. So, this adds instructions to enable cilium debug logs before the first authentication happens after enforcing mutual authentication.

@sudeephb sudeephb requested review from a team as code owners August 5, 2025 07:55
@sudeephb sudeephb requested review from sayboras and qmonnet August 5, 2025 07:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 5, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 5, 2025
qmonnet
qmonnet requested changes Aug 5, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please fix your commit (and PR) title: “enable debug information before ...” rather than “cilium docs”?

I'd also recommend using a real email address in your sign-off.

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Aug 5, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 5, 2025
@sudeephb
docs: enable debug information before first authentication in mutual …
9165efa 
…auth example

Signed-off-by: sudeephb <sudeephb19@gmail.com>
@sudeephb sudeephb changed the title docs: enable cilium docs before first authentication in mutual auth example docs: enable debug information before first authentication in mutual auth example Aug 5, 2025
@sudeephb sudeephb requested a review from qmonnet August 5, 2025 16:23
qmonnet
qmonnet approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@qmonnet
Copy link
Member

qmonnet commented Aug 6, 2025

/test

@joestringer joestringer added this pull request to the merge queue Aug 20, 2025
@joestringer
Copy link
Member

Looks like this was blocked due to lack of review from @cilium/sig-servicemesh , but the change is straightforward. I've queued it to merge. Thanks for your contribution @sudeephb.

Merged via the queue into cilium:main with commit 4d2376a Aug 20, 2025
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@sayboras sayboras Awaiting requested review from sayboras sayboras is a code owner automatically assigned from cilium/sig-servicemesh

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudeephb @qmonnet @joestringer