policy / hubble: fix segfault on startup when hubble enabled #40824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@squeed thanks for the quick patch! Could you add a corresponding unit test on the way please? |
@kaworu I'll try; mocking out endpoints is tricky business. But it's a good exercise. |
e0a689f to
e522668
Compare
In the event that a regeneration failed, we re-populated the MapState but forgot to set the rule origin. Unfortunately, the zero value for Handle is not equivalent to nil; we must always set it explicitly. Use the constructor instead. Fixes: fe165aa Signed-off-by: Casey Callendrello <cdc@isovalent.com>
e522668 to
dd99031
Compare
|
(Added a unit test :-)) |
|
/test |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that a regeneration failed, we re-populated the MapState but forgot to set the rule origin. Unfortunately, the zero value for Handle is not equivalent to nil; we must always set it explicitly.
Fixes: fe165aa