Skip to content

Conversation

tklauser
Copy link
Member

Remove unused code from the pkg/k8s package, see individual commit messages for references to the commits removing the last remaining user of the respective symbol.

@tklauser tklauser requested a review from a team as a code owner July 30, 2025 09:18
@tklauser tklauser requested a review from marseel July 30, 2025 09:18
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jul 30, 2025
@tklauser tklauser enabled auto-merge July 30, 2025 09:22
tklauser added 4 commits July 30, 2025 11:47
It's unused since commit 505e849 ("daemon,k8s: ServiceCache
interface in preparation for adapter").

Signed-off-by: Tobias Klauser <tobias@cilium.io>
These are unused since commit c2b9350 ("bgp: remove metallb bgp
integration").

Signed-off-by: Tobias Klauser <tobias@cilium.io>
It's unused since it was converted from Resource to Table in commit
6a4fe9c ("daemon/k8s: Replace Resource[Pod] with Table[LocalPod]").

Signed-off-by: Tobias Klauser <tobias@cilium.io>
It's unused since commit ce0c355 ("k8s: Remove ServiceCache and
Service").

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@aanm aanm force-pushed the pr/tklauser/k8s-remove-unused-code branch from 8f5bc00 to ac454d8 Compare July 30, 2025 09:47
@tklauser
Copy link
Member Author

/test

Copy link
Contributor

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Thanks!

@tklauser tklauser added this pull request to the merge queue Jul 31, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 31, 2025
Merged via the queue into main with commit c66015a Jul 31, 2025
367 of 372 checks passed
@tklauser tklauser deleted the pr/tklauser/k8s-remove-unused-code branch July 31, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants